OpenCSW Bug Tracker


Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004650 [cswutils] regular use block always 2010-12-31 16:40 2011-04-24 04:50
Reporter pfelecan View Status public  
Assigned To phil
Priority high Resolution fixed  
Status closed  
Summary 0004650: checkpkg: wrong detection of package compression
Description The detection of the compression of the package is wrong.

In the following construct:

file $f |sed 's/^.*://' |grep gzip >/dev/null

the sed regex is too greedy when gnulinks package is installed and file is gfile; the output contains 2 :

The correct construct is:

file $f |sed 's/^[^:]*://' |grep gzip >/dev/null

IMHO the sed is not realy useful...
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0008934)
bwalton (administrator)
2011-03-19 18:18

Phil: Please fix this bug and let me know when it's ready for an updated checkpkg release.

Thanks
-Ben
(0008937)
phil (reporter)
2011-03-20 22:54

Note to Peter:
The bigger problem, is that "gnu file" has drastically different output from "file"... which is exactly why I personally dont put /opt/csw/gnu in my normal path.

So, I think the best fix for this, is to ensure consistent output, by forcing use of system file.
Which I have now done. Fix in svn, Ben

btw, I dont tend to put things in for no reason. The sed is there, so that it correctly determines file type for things that have "gzip" in their name. such as the gzip package itself. or pkgzip. etc, etc.
(0008992)
bwalton (administrator)
2011-04-24 04:50

Updated release pushed.


Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker