Mantis - cswutils
Viewing Issue Advanced Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
4650 regular use block always 2010-12-31 16:40 2011-04-24 04:50
Reporter: pfelecan Platform:  
Assigned To: phil OS:  
Priority: high OS Version:  
Status: closed Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
Summary: 0004650: checkpkg: wrong detection of package compression
Description: The detection of the compression of the package is wrong.

In the following construct:

file $f |sed 's/^.*://' |grep gzip >/dev/null

the sed regex is too greedy when gnulinks package is installed and file is gfile; the output contains 2 :

The correct construct is:

file $f |sed 's/^[^:]*://' |grep gzip >/dev/null

IMHO the sed is not realy useful...
Steps To Reproduce:
Additional Information:
Relationships
Attached Files:
Issue History
Date Modified Username Field Change
2010-12-31 16:40 pfelecan New Issue
2011-03-19 18:18 bwalton Status new => assigned
2011-03-19 18:18 bwalton Assigned To => phil
2011-03-19 18:18 bwalton Note Added: 0008934
2011-03-20 22:54 phil Note Added: 0008937
2011-04-24 04:50 bwalton Note Added: 0008992
2011-04-24 04:50 bwalton Status assigned => closed
2011-04-24 04:50 bwalton Resolution open => fixed

Notes
(0008934)
bwalton   
2011-03-19 18:18   
Phil: Please fix this bug and let me know when it's ready for an updated checkpkg release.

Thanks
-Ben
(0008937)
phil   
2011-03-20 22:54   
Note to Peter:
The bigger problem, is that "gnu file" has drastically different output from "file"... which is exactly why I personally dont put /opt/csw/gnu in my normal path.

So, I think the best fix for this, is to ensure consistent output, by forcing use of system file.
Which I have now done. Fix in svn, Ben

btw, I dont tend to put things in for no reason. The sed is there, so that it correctly determines file type for things that have "gzip" in their name. such as the gzip package itself. or pkgzip. etc, etc.
(0008992)
bwalton   
2011-04-24 04:50   
Updated release pushed.