0004816: Typo in SMF start method of puppet agent

(0009230)
markp (developer)
2011-08-11 22:21

Oh, clearly I was having a dozy day. I'll sort that.

Thanks for spotting!

(0009231)
markp (developer)
2011-08-11 22:24

OK, the variable isn't referenced at all - just set up. So it makes no difference anyway.

(0009232)
ja (developer)
2011-08-12 05:18

Oh, my fault, you are right.

But anyway, there is something, which doesn't work as it should, I think. When the variables $confdir, $vardir and $ssldir are enabled in the start script and puppet is started like this

${sbindir}/puppetd --confdir=$confdir --vardir=$vardir --ssldir=$ssldir

it behaves in a different way (it behaves as I would expect) than when it's started just with

${sbindir}/puppetd

My /etc/puppet/puppet.conf looks like this (OpenCSW default):

[main]
    confdir = /etc/opt/csw/puppet
    config = $confdir/puppet.conf
    vardir = /var/opt/csw/puppet
    ssldir = $vardir/ssl

It seems, that puppet doesn't read $confdir/puppet.conf , at least it ignores some settings in it like $runinterval. Only when starting puppet with the option --confdir=/etc/opt/csw/puppet this works.

I cannot track this thing down further. If needed I could open another ticket, as the original "problem" is solved.

(0009233)
markp (developer)
2011-08-12 10:24

OK, I see your point - you're trying to run it as per the README.CSW in /etc/puppet? It must be that /etc/puppet/puppet.conf isn't chaining onto the /etc/opt/csw file. The answer is, as you've found out, run it with --config= or --confdir=

I'll look at changing the README file to reflect this behaviour.

(0009234)
markp (developer)
2011-08-12 10:25

It's puppet behaviour. Could do with updating the README.CSW file to better reflect it though.

(0009240)
ja (developer)
2011-08-14 20:35

What about changing the start skript to run puppet with --config or --confdir? It's more intuitive for the user. You could create /etc/puppet and document it per README.CSW

Otherwise a user has to change the start skript, which is - in my opinion - not so "nice". Changing a configuration is one thing, changing a start skript is another (again, my opinion). After upgrading a package the config file will be overwritten and then the software doesn't work and it's monday, the admin is in vacation ... you know ;-)

Just my two cents.

(0009364)
markp (developer)
2011-10-24 22:37

README updated for next release (after 2.6.12 24.10.11)

Notes
(0009230) markp (developer) 2011-08-11 22:21	Oh, clearly I was having a dozy day. I'll sort that. Thanks for spotting!

(0009231) markp (developer) 2011-08-11 22:24	OK, the variable isn't referenced at all - just set up. So it makes no difference anyway.

(0009232) ja (developer) 2011-08-12 05:18	Oh, my fault, you are right. But anyway, there is something, which doesn't work as it should, I think. When the variables $confdir, $vardir and $ssldir are enabled in the start script and puppet is started like this ${sbindir}/puppetd --confdir=$confdir --vardir=$vardir --ssldir=$ssldir it behaves in a different way (it behaves as I would expect) than when it's started just with ${sbindir}/puppetd My /etc/puppet/puppet.conf looks like this (OpenCSW default): [main] confdir = /etc/opt/csw/puppet config = $confdir/puppet.conf vardir = /var/opt/csw/puppet ssldir = $vardir/ssl It seems, that puppet doesn't read $confdir/puppet.conf , at least it ignores some settings in it like $runinterval. Only when starting puppet with the option --confdir=/etc/opt/csw/puppet this works. I cannot track this thing down further. If needed I could open another ticket, as the original "problem" is solved.

(0009233) markp (developer) 2011-08-12 10:24	OK, I see your point - you're trying to run it as per the README.CSW in /etc/puppet? It must be that /etc/puppet/puppet.conf isn't chaining onto the /etc/opt/csw file. The answer is, as you've found out, run it with --config= or --confdir= I'll look at changing the README file to reflect this behaviour.

(0009234) markp (developer) 2011-08-12 10:25	It's puppet behaviour. Could do with updating the README.CSW file to better reflect it though.

(0009240) ja (developer) 2011-08-14 20:35	What about changing the start skript to run puppet with --config or --confdir? It's more intuitive for the user. You could create /etc/puppet and document it per README.CSW Otherwise a user has to change the start skript, which is - in my opinion - not so "nice". Changing a configuration is one thing, changing a start skript is another (again, my opinion). After upgrading a package the config file will be overwritten and then the software doesn't work and it's monday, the admin is in vacation ... you know ;-) Just my two cents.

(0009364) markp (developer) 2011-10-24 22:37	README updated for next release (after 2.6.12 24.10.11)

Relationships

OpenCSW Bug Tracker