0004543: Configuration migration doesn't work properly if a directory is given

OpenCSW Bug Tracker

Project:

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0004543

[cas_migrateconf] regular use

minor

always

2010-09-03 14:54

2015-11-26 12:42

Reporter

yann

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Summary

0004543: Configuration migration doesn't work properly if a directory is given

Description

Hi,

According to the wiki page, cswclassutils cswmigrateconf class action script can migrate a whole directory: "If a path specified in MIGRATE_FILES is a directory, the whole directory tree is going to be copied." [1]

However I was not able to use this mode successfully with vsftpd.
It seems that before doing the migration, the script always tries to test the existence of /etc/opt/csw/vsftpd.CSW which is not applicable in the directory case:

  # If there's a sample configuration file, remove the copied one.
  __sample_conf="${__dest_file_name}.CSW"
  if [ -r "${__sample_conf}" ]; then
    if files_are_identical "${__sample_conf}" "${__dest_file_name}"; then
      return "${__do_copy}"
    else
      return "${__do_not_copy}"
    fi
  fi

Have I done something wrong or is it a bug ?

Thanks in advance for your answer.

[1] http://wiki.opencsw.org/cswclassutils-package#toc15 [^]

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0008262) maciej (manager) 2010-09-03 16:32	You probably spotted a bug. The directory case wasn't tested well. What do you think would be a good fix? Testing whether __dest_file_name is a directory, and have a separate clause for it?

(0010783) maciej (manager) 2014-03-24 00:50	There is no point in waiting for this bug to be fixed. If you want it fixed, you (yes, you the reader) need to fix it yourself. If you're not already a package maintainer at OpenCSW, you can look at the 35 minute long tutorial[1] to get started - then you can offer your patch to package maintainers. You can find OpenCSW people on the users mailing list[2] and on the #opencsw channel on IRC on Freenode[3]. [1] Packaging tutorial http://youtu.be/JWKCbPJSaxw [^] [2] OpenCSW users mailing list https://lists.opencsw.org/mailman/listinfo/users [^] [3] #opencsw on Freenode http://www.opencsw.org/support/irc-channel/ [^]