Mantis - tcl
Viewing Issue Advanced Details
4652 packaging major always 2011-01-02 13:13 2012-10-26 11:05
pfelecan  
dam  
normal  
feedback  
open  
none    
none  
0004652: uncomplete packaging
Some projects use Tcl/Tk to provide a graphical interface, e.g., gdb. For that, they need some "private headers" situated in /opt/csw/include/tcl-private. The current package doesn't contain these components.
Issue History
2011-01-02 13:13 pfelecan New Issue
2012-10-03 16:13 dam Status new => assigned
2012-10-03 16:13 dam Assigned To => dam
2012-10-03 16:14 dam Note Added: 0010156
2012-10-03 16:14 dam Status assigned => feedback
2012-10-04 16:23 pfelecan Note Added: 0010164
2012-10-04 16:35 dam Note Added: 0010165
2012-10-05 10:06 pfelecan Note Added: 0010166
2012-10-05 10:38 pfelecan Note Edited: 0010166
2012-10-05 12:05 dam Note Added: 0010167
2012-10-05 15:52 pfelecan Note Added: 0010168
2012-10-22 23:41 dam Note Added: 0010194
2012-10-26 11:05 pfelecan Note Added: 0010197

Notes
(0010156)
dam   
2012-10-03 16:14   
CSWtcl-dev 8.5.12,REV=2012.09.10 should contain the private headers, although in the standard location. Would you mind giving it a try?
(0010164)
pfelecan   
2012-10-04 16:23   
I tried with gdb and it doesn't detect the "private Tcl headers" as it looks for the value of TCL_INCLUDE_SPEC from /opt/csw/lib/tclConfig.sh to which it appends /tcl-private/generic; the resulting path must contain the tclInt.h

This is the "standard" configure way to test the existence of the Tcl components to generate the corresponding binding.

I think that the same is true for Tk.
(0010165)
dam   
2012-10-04 16:35   
Hi Peter,

the appending of /tcl-private/generic was only valid in the old TCL, the current CSWtcl-dev has tclInt.h in /opt/csw/include as specified in tclConfig.sh:
  TCL_INCLUDE_SPEC='-I/opt/csw/include'
I suggest patching the detect to not append anything.
(0010166)
pfelecan   
2012-10-05 10:06   
(edited on: 2012-10-05 10:38)
IMHO, patching is not the best option.

The detection mechanism is implemented in an autoconf file, e.g. tcl.m4 in /opt/csw/share/aclocal. BTW, the corresponding file is missing in your package.

If you take a look in the Debian package, you can see that in tcl 8.5 the detection mechanism changed and that is reflected in the tcl8.5.m4

A lot of other projects offering bindings with Tcl use this mechanism. If we wish to provide a good maintainer experience we should follow the usages of the community.

(0010167)
dam   
2012-10-05 12:05   
Sure, should I just add unix/tcl.m4 from the distribution to CSWtcl-dev at /opt/csw/share/aclocal ?
Or is there something else needed?
(0010168)
pfelecan   
2012-10-05 15:52   
Adding unix/tcl.m4 is a good thing. Additionally, preserving the private structure is also necessary (Debian gives you a good example)
(0010194)
dam   
2012-10-22 23:41   
I browsed around the debian site but couldn't find the build description. Would you mind dropping a link?
(0010197)
pfelecan   
2012-10-26 11:05   
The recipe itself is http://ftp.de.debian.org/debian/pool/main/t/tcl8.5/tcl8.5_8.5.11-2.debian.tar.gz [^] and the global maintainer page is http://packages.qa.debian.org/t/tcl8.5.html [^]