OpenCSW Bug Tracker


Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004064 [dhcp] packaging feature N/A 2009-12-03 13:29 2010-02-16 10:02
Reporter skayser View Status public  
Assigned To bonivart
Priority normal Resolution fixed  
Status closed  
Summary 0004064: RFE: Extend init script with a "restart" option
Description To have dhcpd reload its configuration i currently do

    /etc/opt/csw/init.d/cswdhcpd stop
    /etc/opt/csw/init.d/cswdhcpd start

Could we get a

    /etc/opt/csw/init.d/cswdhcpd restart

instead? Possibly with configuration file syntax checking before the stop so that the service is only stopped when the configuration file is sane. Something like httpd -S (in case dhcpd offers it).
Additional Information # pkgparam CSWdhcp VERSION
4.1.1b2,REV=2009.08.13
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0007061)
bonivart (manager)
2009-12-03 13:53

Sure, I can fix that as soon as the farm is online again.
(0007070)
bonivart (manager)
2009-12-07 16:52

I have put beta 3 packages in testing now. The init script has an added restart option that tries to look at both the configuration and the lease file before stopping the running server.

This is totally untested though so maybe you could test it and get back to me? I will fix/add any problems/features.
(0007080)
skayser (administrator)
2009-12-10 19:44

FAIL needs some quotes to prevent a syntax error.

diff cswdhcpd.org cswdhcpd
36,38c36,38
< [ $FAIL = 1 ] && echo "Your configuration seems broken. Exiting."
< [ $FAIL = 2 ] && echo "Your lease file seems broken. Exiting."
< [ $FAIL ] && exit 1
---
> [ "$FAIL" = 1 ] && echo "Your configuration seems broken. Not restarting."
> [ "$FAIL" = 2 ] && echo "Your lease file seems broken. Not restarting."
> [ "$FAIL" ] && exit 1

Also, I just noticed funny things with SMF on Solaris 10. Even if there is a restart option, SMF only seems to trigger stop and start.

# svcadm restart cswdhcp
# /var/svc/log/network-cswdhcpd\:default.log
...
[ Dec 10 19:39:59 Stopping because service restarting. ]
[ Dec 10 19:39:59 Executing stop method ("/var/opt/csw/svc/method/svc-cswdhcpd stop") ]
Stopping dhcp.
[ Dec 10 19:39:59 Method "stop" exited with status 0 ]
[ Dec 10 19:39:59 Executing start method ("/var/opt/csw/svc/method/svc-cswdhcpd start") ]
Starting dhcp.
...
(0007082)
bonivart (manager)
2009-12-10 23:45

Thanks for fixing the script.

Regarding the SMF restart, I have to take a look at it. You should have gotten the line with "waiting for dhcp to stop".

I'll see if I get some time tomorrow. I'll update to RC1 which they released the other day, hopefully we will get a final release in a few weeks.
(0007085)
bonivart (manager)
2009-12-11 17:47

4.1.1rc1,REV=2009.12.11 in testing with your changes to the init script. Still untested by me. Sorry about that.

Fortunately ISC haven't done a thing between beta 3 and release candidate 1 so we can probably expect a final release real soon.
(0007293)
bonivart (manager)
2010-01-19 11:19

4.1.1 has been released. Packages in testing.
(0007444)
bonivart (manager)
2010-02-16 10:02

4.1.1 released.


Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker