Mantis - gkrellm
Viewing Issue Advanced Details
1994 other major always 2006-12-03 10:08 2010-03-05 19:22
james  
jgoerzen  
normal  
closed  
fixed  
none    
none  
0001994: local paths in config files
/opt/csw/lib/pkgconfig/gkrellm.pc contains local paths
prefix=/export/home/jgoerzen/pkgs/gkrellm/cswstage/opt/csw
Name: GKrellM
Description: Extensible GTK system monitoring application
Version: 2.2.7
Requires: gtk+-2.0 >= 2.0.0
Cflags: -I/export/home/jgoerzen/pkgs/gkrellm/cswstage/opt/csw/include
Issue History
2010-02-16 22:50 jgoerzen Note Added: 0007456
2010-02-16 22:50 jgoerzen Assigned To => jgoerzen
2010-02-16 22:50 jgoerzen Status new => feedback
2010-02-17 12:17 james Note Added: 0007461
2010-02-20 00:06 jgoerzen Note Added: 0007483
2010-03-03 18:01 jgoerzen Note Added: 0007580
2010-03-03 18:01 jgoerzen Status feedback => resolved
2010-03-03 18:01 jgoerzen Resolution open => fixed
2010-03-05 19:22 jgoerzen Status resolved => closed

Notes
(0007456)
jgoerzen   
2010-02-16 22:50   
committed GAR build recipe 8598 fixes local paths in gkrellm.pc

updated packages are available in testing/

gkrellm-2.3.4,REV=2010.02.16-SunOS5.8-i386-CSW.pkg.gz
gkrellm-2.3.4,REV=2010.02.16-SunOS5.8-sparc-CSW.pkg.gz
(0007461)
james   
2010-02-17 12:17   
The pc file is good. I've run the package through the general path check and it throws up:

/usr/local/ found in file /opt/csw/include/gkrellm2/gkrellm.h
/usr/local/ found in file /opt/csw/bin/gkrellm

The include has within some ifs and buts:

#define LOCAL_THEMES_DIR "/usr/local/share/gkrellm2/themes"

Should this be /opt/csw/share/... ? I can't see themes in any package, does the user add these? Not knowing what the package does it's hard for me to say what is right but I'm asking the question.
(0007483)
jgoerzen   
2010-02-20 00:06   
Yes, should be /opt/csw/share. The themes are like xmms skins the user could add them self or could be packaged up but I haven't gotten around to it yet.

I have created a patch for gkrellm.h that changes occurrences of /usr/local to /opt/csw and then recompiled new packages. They are available in testing/

gkrellm-2.3.4,REV=2010.02.19-SunOS5.8-i386-CSW.pkg.gz
gkrellm-2.3.4,REV=2010.02.19-SunOS5.8-sparc-CSW.pkg.gz
gkrellmd-2.3.4,REV=2010.02.19-SunOS5.8-i386-CSW.pkg.gz
gkrellmd-2.3.4,REV=2010.02.19-SunOS5.8-sparc-CSW.pkg.gz

Thanks!
(0007580)
jgoerzen   
2010-03-03 18:01   
fixed in REV=2010.03.01 released to current/